From cb7c05a0b50921489d1bb118bc0d67d08491e7b8 Mon Sep 17 00:00:00 2001 From: Diego Sampaio Date: Fri, 25 Sep 2020 00:16:27 -0300 Subject: [PATCH] Obbey to settings properties (#19020) --- app/authorization/server/streamer/permissions/emitter.js | 5 ++++- server/publications/settings/emitter.js | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/authorization/server/streamer/permissions/emitter.js b/app/authorization/server/streamer/permissions/emitter.js index a7062439eb46..5b0a2a13f9b4 100644 --- a/app/authorization/server/streamer/permissions/emitter.js +++ b/app/authorization/server/streamer/permissions/emitter.js @@ -32,7 +32,10 @@ Permissions.on('change', ({ clientAction, id, data, diff }) => { // if the permission changes, the effect on the visible settings depends on the role affected. // The selected-settings-based consumers have to react accordingly and either add or remove the // setting from the user's collection - const setting = Settings.findOneById(data.settingId); + const setting = Settings.findOneNotHiddenById(data.settingId); + if (!setting) { + return; + } Notifications.notifyLoggedInThisInstance( 'private-settings-changed', 'updated', diff --git a/server/publications/settings/emitter.js b/server/publications/settings/emitter.js index 2a9312b22548..20a336644271 100644 --- a/server/publications/settings/emitter.js +++ b/server/publications/settings/emitter.js @@ -17,6 +17,10 @@ Settings.on('change', ({ clientAction, id, data, diff }) => { properties: setting.properties, }; + if (setting.hidden) { + return; + } + if (setting.public === true) { Notifications.notifyAllInThisInstance('public-settings-changed', clientAction, value); }