Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Import for one channel does not work because of "Missed import types: { thread_broadcast: ..." #12676

Closed
svrnwnsch opened this issue Nov 20, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@svrnwnsch
Copy link

Description:

I cannot import one channel of my Slack export into Rocket.Chat.
The debug lock is telling me:

Slack Importer ➔ debug Slack is now at importer_importing_messages.
Meteor ➔ method getImportProgress -> userId: XXXXXXXXXXXX , arguments:  [ 'slack' ]
Missed import types: { thread_broadcast: 
   { text: 'XXXXXXXX',
     unfurl_links: true,
     client_msg_id: 'XXXXXXXXXX',
     unfurl_media: true,
     thread_ts: 'XXXXXXXXX',
     is_thread_broadcast: true,
     attachments: [ [Object] ],
     type: 'message',
     subtype: 'thread_broadcast',
     user: 'YYYYYYYYYY',
     root: 
      { type: 'message',
        user: 'YYYYYYYYY',
        text: 'XXXXXXXXXX',
        attachments: [Array],
        thread_ts: 'XXXXXXX',
        reply_count: 1,
        replies: [Array],
        unread_count: 1,
        ts: 'XXXXXXXX' },
     ts: 'XXXXXXXXX' } }
Slack Importer ➔ debug Slack is now at importer_finishing.

I guess that the subtype: thread_broadcast is not working?

I am running rocket.chat version 0.71.1

@engelgabriel engelgabriel added this to the 1.0.0 milestone Mar 21, 2019
@engelgabriel engelgabriel added the feat: threads / discussions Threads and Discussions label Mar 21, 2019
@engelgabriel
Copy link
Member

We have decided that was better to delay our v1 release and get the Threads done properly than get the feature out the way it was initially implemented on the develop branch. We have "rebranded" our current implementation of Threads to Discussions (was it creates a new room type) and will implement Threads exactly the same way as Slack does.

In our vision there are 2 different use cases on how to break out of the main conversation: one very easy and organic, with a single click for small side talk, and other, much more structured, that creates a new conversation with its own life cycle.

We have tried to have a single solution for both, and as a result, no one was happy with it.
So we have given up on having a single approach for both use cases and will implement both: the Slack-like industry standard and our brand new one, called Discussions.

#13843

@engelgabriel
Copy link
Member

#1112

@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@engelgabriel engelgabriel modified the milestones: 1.1.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@rodrigok rodrigok assigned pierre-lehnen-rc and unassigned Hudell Sep 19, 2019
@engelgabriel engelgabriel modified the milestones: 2.0.0, 2.2.0 Oct 13, 2019
@engelgabriel engelgabriel modified the milestones: 2.2.0, 4.1.0 Mar 17, 2020
@lpilz
Copy link
Contributor

lpilz commented May 10, 2020

This should be closed by #17130

@engelgabriel engelgabriel modified the milestones: 4.1.0, 3.2.0 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants