Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is ufs somewhere in url the request to api always returns 404 #16174

Closed
lastsecondsave opened this issue Jan 9, 2020 · 4 comments · Fixed by #18874
Closed

If there is ufs somewhere in url the request to api always returns 404 #16174

lastsecondsave opened this issue Jan 9, 2020 · 4 comments · Fixed by #18874
Assignees
Labels
feat: api feat: rest Tasked Added to the internal issue tracking type: bug
Milestone

Comments

@lastsecondsave
Copy link

Description:

We have one user for which requests to users.info fail with 404 even if the user is in the database. After some experiments we found that if url contains ufs string the Rocket.Chat always returns 404 with no body. In out case userId contains ufs. We checked open.rocket.chat and it has the same behavior. Any api request fails when ufs is somewhere in the url.

Steps to reproduce:

  1. Query this endpoints:
https://open.rocket.chat/api/v1/users.info?userId=123
https://open.rocket.chat/api/v1/users.info?userId=ufs

Expected behavior:

They behave the same, either ask you to log in or return "bad request".

Actual behavior:

For the second endpoint you will always get 404.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.3.2, 2.4.0
@MarcosSpessatto
Copy link
Member

Hello @lastsecondsave, first of all, thanks for investigating the problem and let us know.
Seeing the problem that you described, I noticed that this problem occurs inside one of our external dependencies, as you can see here. Basically that code verify if there is a ufs string inside the url and if it is true, the package understands as if it were a request to the the package (file-upload/store in this case). We are under many improvements on our code base and starting to change these Meteor's packages to npm packages is a priority.

@sistason
Copy link

Has there been any progress yet?
Or a rough estimation, if that is more a "nice to have" or more a "fixed when X happend, which will be in feature Y"? :)

@tomplaskon
Copy link

Any update here? This is creating some serious problems for us.

@sampaiodiego
Copy link
Member

we'll be working on a fix for this as soon the next release cycle begins..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: api feat: rest Tasked Added to the internal issue tracking type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants