Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive server data exposed for non logged in users. #1731

Closed
maxsdw opened this issue Dec 22, 2015 · 10 comments
Closed

Sensitive server data exposed for non logged in users. #1731

maxsdw opened this issue Dec 22, 2015 · 10 comments

Comments

@maxsdw
Copy link
Contributor

maxsdw commented Dec 22, 2015

When accessing to "/api/info", some data like server OS, kernel version, cpu and ram, as well as other sensitive data is exposed, this could represent a security issue. All sensitive information should be remove from this response.

@mrj0b
Copy link

mrj0b commented Dec 22, 2015

i can confirm this on https://demo.rocket.chat/api/info

@matthias-brun
Copy link
Contributor

Perhaps make the information visible somewhere on the administration pages and disable "/api/info" for production systems?

@engelgabriel
Copy link
Member

we use the /api/info on the Mobile and Desktop clients.. to validate the version of Rocket.Chat before they attempt to login.

@matthias-brun
Copy link
Contributor

I see, then is there a reason for information such as kernel version or available ram also being publicly exposed? Could just remove that information from it.

@engelgabriel
Copy link
Member

it was mainly to help us give better support, but you are right, we will remove that.

@Sing-Li
Copy link
Member

Sing-Li commented Dec 28, 2015

we might want to public-key encrypt a sysinfo-blob for support ?

@geekgonecrazy
Copy link
Contributor

Maybe we just make this route only available to admin? Because I do think some points the info could be good for troubleshooting.

I also like the idea of pub-key encrypt

@MartinSchoeler
Copy link
Contributor

Today you only get the chat version from api/info. If there is still something relevant in this issue, please reopen this with updated details. Thanks!

@localguru
Copy link
Contributor

localguru commented May 29, 2017

Question: would it be a problem to block "/api/info" on nginx proxy side, e.g.:

	location ~ ^/apt/info {
		deny all;
	}

Or has it still to be public for mobile and desktop clients?

@geekgonecrazy
Copy link
Contributor

@localguru I believe the new Android app uses this. The iOS app possibly uses this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants