Auto Load Images is no longer working

[dbussert]

Did a 1-click deploy on Heroku for someone else, and the site is running fine, except no images are autoloading. My user's Auto Load Images setting is default to true. I went to an older version of Rocket.Chat on a VM I have an auto-loads work fine, so this leads me to believe this feature broken at some point recentyl.

[graywolf336]

Try something, go to the admin panel and change the "Allow invalid and Self-Signed SSL certificate's for link validation and previews" setting to allow and see if it works then:

[dbussert]

@graywolf336 I deployed it right before that commit, so the setting wasn't there. I blew that app away and did it again to get the latest commit. I set it to true and no change, still does not auto-load.

[graywolf336]

That's as far as I can help, I haven't used it before with Heroku...sorry

[geekgonecrazy]

@dbussert alright when you say auto loading isn't working. Is it showing something like this?

Also is this only happening on uploads or link previews or both?

[dbussert]

more info, I took an older version of Rocket.Chat and upgraded it to latest and embeds work fine. But deleting it and cloning off master embeds do not work. I'll try cloning off some different commits and see if I can find more info.

[dbussert]

@geekgonecrazy I'm specifically testing auto-loading images, but its both off pasted urls and uploads

[geekgonecrazy]

@dbussert ok. Does it show the click to load image? If so does clicking it load? We need to make sure its getting that far.

[dbussert]

@geekgonecrazy neither of those, no action when pasting in a link

[geekgonecrazy]

Ok so this has something to do with the metadata collection step happening server side. I'll try a heroku deploy and see what I come up with.

If you want a bit more rapid troubleshooting. Please feel free to join https://demo.rocket.chat and hit up the #general or #support channels.

[geekgonecrazy]

@dbussert just an update. I am able to reproduce this. Working on trying to fix it now.

[kakawait]

FYI using https://hub.docker.com/_/rocket.chat/ images loading work fines, using latest code (cloned from git) version with https://hub.docker.com/r/danieldent/meteor/ images loading does not work (even with self-signed certificat option).

So is not specific to heroku

[kakawait]

If it can help git bisect for gif autoloading test said me:

abf9acca9663d41aeeb30e94d0441dffe756b889 is the first bad commit
commit abf9acca9663d41aeeb30e94d0441dffe756b889
Author: Marcelo Schmidt <marcelo.schmidt@konecty.com>
Date:   Mon Aug 17 21:54:04 2015 -0300

    Settings: API_Embed; closes #225

So it's seems to be new configuration (see #225)

[kakawait]

Flood! After testing issue is part of server not client. Be removing following line

Rocket.Chat/packages/rocketchat-oembed/server/server.coffee

Line 173 in abf9acc

if RocketChat.settings.get 'API_Embed'

gif autoloading test works.

EDIT issue could only appears when starting with empty mongo db, in fact

Rocket.Chat/packages/rocketchat-oembed/server/server.coffee

Line 173 in abf9acc

if RocketChat.settings.get 'API_Embed'

is call before https://github.com/RocketChat/Rocket.Chat/blob/master/packages/rocketchat-lib/settings/server/startup.coffee that set RocketChat.settings.add 'API_Embed', true, { type: 'boolean', group: 'API', public: true }

Thus we got the following error SyntaxError: Unexpected string

If you restart server bug disappear but I think it should be fix.

[rodrigok]

This issue probably was resolved by PR #849, if not, please reopen.

[GaWr26]

Unfortunately I can't get the inline image preview.

We did empty the database. Is there any way to enable this again. restarting the server didn't work.
youtube and urls do show a preview though.