Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image autoloading does not work behind proxy #851

Closed
kakawait opened this issue Sep 22, 2015 · 4 comments
Closed

Image autoloading does not work behind proxy #851

kakawait opened this issue Sep 22, 2015 · 4 comments

Comments

@kakawait
Copy link
Contributor

Autoloading gif/image feature is important feature for our team building (or flaming) but when using Rocket.Chat behind corporate proxy feature is broken even with http_proxy and https_proxy variable set.

Indeed you are using http or https package from NodeJs that does not respect env variable like http_proxy or https_proxy.

In order to support proxy you should:

  1. Try request package instead that respect env variable (https://github.com/request/request#controlling-proxy-behaviour-using-environment-variables)
  2. Use such package https://www.npmjs.com/package/http-proxy-agent with http/https to handle proxy for both http and https (more information http://blog.vanamco.com/proxy-requests-in-node-js/)
@vpusher
Copy link

vpusher commented Sep 22, 2015

👍

@kakawait
Copy link
Contributor Author

If it's candidate to contribution/PR you should decide if it's possible to remove http/https node package for request package or you want to keep them and try to enable proxy feature on them?

I know that corporate proxy features is specific but for a self-hosted solution is really important (in my mind), but it can be also difficult for you to develop it if you are proxy-less environment.

@indiggio
Copy link

👍

@Sing-Li
Copy link
Member

Sing-Li commented Oct 22, 2015

Closing this one instead of #1194 - hopefully some Digital Ocean hackers will pick it up and add a fix soon. Thanks @kakawait !

@Sing-Li Sing-Li closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants