Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.13 #13

Closed
gotmax23 opened this issue Jun 13, 2024 · 1 comment · Fixed by #14
Closed

Add support for Python 3.13 #13

gotmax23 opened this issue Jun 13, 2024 · 1 comment · Fixed by #14

Comments

@gotmax23
Copy link
Contributor

The package currently fails to build with Python 3.13 due to changes in the Python C API:

  src/bin_ext/macro_functions.h: In function ‘set_c_parameters’:
  src/bin_ext/macro_functions.h:17:27: error: implicit declaration of function ‘_PyLong_AsInt’; did you mean ‘PyLong_AsInt’? [-Wimplicit-function-declaration]
     17 |         const int level = _PyLong_AsInt(level_or_option);
        |                           ^~~~~~~~~~~~~
        |                           PyLong_AsInt
mikelolasagasti added a commit to mikelolasagasti/pyzstd that referenced this issue Jun 14, 2024
@mikelolasagasti
Replace _PyLong_AsInt() with PyLong_AsInt()
d4c83a9 
The new public function PyLong_AsInt() has been introduced as part of
python/cpython#108444 which renames the
internal _PyLong_AsInt() to PyLong_AsInt().

Fixes Rogdham#13

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@mikelolasagasti mikelolasagasti mentioned this issue Jun 14, 2024
Merged
mikelolasagasti added a commit to mikelolasagasti/pyzstd that referenced this issue Jun 14, 2024
@mikelolasagasti
Replace _PyLong_AsInt() with PyLong_AsInt() for Python 3.13+
2c394fb 
The new public function `PyLong_AsInt()` has been introduced as part of
python/cpython#108444, which renames the
internal `_PyLong_AsInt()` to `PyLong_AsInt()`. This change updates the
code to use the new public API while maintaining compatibility with
Python versions earlier than 3.13.

Fixes Rogdham#13

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@Rogdham
Copy link
Owner

Rogdham commented Jun 16, 2024

Thank you for the heads up about the breaking change in the next version of Python!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace _PyLong_AsInt() with PyLong_AsInt() for Python 3.13+ mikelolasagasti/pyzstd
2 participants
@Rogdham @gotmax23