Replace _PyLong_AsInt() with PyLong_AsInt() for Python 3.13+ #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelolasagasti
changed the title
mikelolasagasti
force-pushed
the
PyLong_AsInt_public
branch
from
d4c83a9
to
2c394fb
Compare
Context in python/cpython#108444 Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Rogdham
force-pushed
the
PyLong_AsInt_public
branch
from
2c394fb
to
fb8efdd
Compare
|
Thank you for the PR! I have changed the version check to replicate the one in https://github.com/python/pythoncapi-compat/blob/18d1df75c72a4ac38fc0a934c13ab6de081a19d2/pythoncapi_compat.h#L887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new public function
PyLong_AsInt()has been introduced as part of python/cpython#108444, which renames the internal_PyLong_AsInt()toPyLong_AsInt(). This change updates the code to use the new public API while maintaining compatibility with Python versions earlier than 3.13.Fixes #13