From 72e791db8729fa7f8a2e756acb069e2cedae96d2 Mon Sep 17 00:00:00 2001 From: bernhard Date: Thu, 23 Sep 2021 10:23:46 +0200 Subject: [PATCH] Issue #1147: enhance some code comments concerning the PackageIsDownloadable flag --- Kernel/Modules/AdminPackageManager.pm | 7 ++++--- Kernel/System/Console/Command/Dev/Package/Build.pm | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Kernel/Modules/AdminPackageManager.pm b/Kernel/Modules/AdminPackageManager.pm index fe9a64826f..2375644594 100644 --- a/Kernel/Modules/AdminPackageManager.pm +++ b/Kernel/Modules/AdminPackageManager.pm @@ -254,6 +254,7 @@ sub Run { PACKAGEACTION: for my $PackageAction (qw(DownloadLocal Rebuild Reinstall)) { + # provide local download button on when the package allows it if ( $PackageAction eq 'DownloadLocal' && ( @@ -431,7 +432,7 @@ sub Run { }, ); - # check if is possible to download files + # check whether it is allowed to download files if ( !defined $Structure{PackageIsDownloadable} || ( @@ -574,7 +575,7 @@ sub Run { Data => { %Param, %Frontend, }, ); - # allow to download only if package is allow to do it + # provide remote download button only when the package allows it if ( !defined $Structure{PackageIsDownloadable} || ( @@ -732,7 +733,7 @@ sub Run { }, ); - # check if is possible to download files + # check whether it is allowed to download files if ( !defined $Structure{PackageIsDownloadable} || ( diff --git a/Kernel/System/Console/Command/Dev/Package/Build.pm b/Kernel/System/Console/Command/Dev/Package/Build.pm index c19c5613a7..4989d9c16a 100644 --- a/Kernel/System/Console/Command/Dev/Package/Build.pm +++ b/Kernel/System/Console/Command/Dev/Package/Build.pm @@ -104,7 +104,7 @@ sub Run { String => $FileString, ); - # just build it if PackageIsDownloadable flag is enable + # Don't build the opm if the PackageIsDownloadable flag is explicitly disabled. if ( defined $Structure{PackageIsDownloadable} && !$Structure{PackageIsDownloadable}->{Content}