Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHA2 does not compile when targeting android with the asm feature #76

Closed
dignifiedquire opened this issue Mar 1, 2019 · 4 comments
Closed

SHA2 does not compile when targeting android with the asm feature #76

dignifiedquire opened this issue Mar 1, 2019 · 4 comments

Comments

@dignifiedquire
Copy link
Member

Error log can be seen here: https://gist.github.com/r10s/a29b59bcd05e3d62b8eb5d9b6273ddd7 it looks like a bunch of instructions that are not available for armv7-linux-androideabi
@newpavlov
Copy link
Member

sha2-asm currently only supports x86 and x86-64. We have plans for using OpenSSL assembly which could add support for ARM targets, but we are not there yet.

@dignifiedquire
Copy link
Member Author

I see, what do you think of adding some cfgs to disable the asm feature when building against other targets?

@newpavlov
Copy link
Member

Yes, I should've added such cfgs. Fixed in RustCrypto/asm-hashes#6.

@dignifiedquire
Copy link
Member Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newpavlov @dignifiedquire