Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detectExecuteScan always scans in RAPID mode on PR builds #4719

Open
drbugfinder-work opened this issue Dec 8, 2023 · 9 comments
Open

detectExecuteScan always scans in RAPID mode on PR builds #4719

drbugfinder-work opened this issue Dec 8, 2023 · 9 comments

Comments

@drbugfinder-work
Copy link
Member

Due to #4211 which contains the addition of

if utils.GetProvider().IsPullRequest() {
log.Entry().Debug("pull request detected")
args = append(args, "--detect.blackduck.scan.mode='RAPID'")
_, err := sys.Client.GetProjectVersion(config.ProjectName, config.Version)
if err == nil {
args = append(args, "--detect.blackduck.rapid.compare.mode='BOM_COMPARE_STRICT'")
}
args = append(args, "--detect.cleanup=false")
args = append(args, "--detect.output.path='report'")
}

a detect scan is always executed in RAPID mode in case of a PR build. There is no way to run a scan in FULL mode through this step anymore since this change.
Setting the mode parameter to FULL results in error:
Unable to parse raw value 'FULL,RAPID', because RAPID is always appended

This behavior needs to be switchable.

@drbugfinder-work
Copy link
Member Author

cc @akram8008 @OliverNocon

Copy link
Contributor

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Feb 10, 2024
@drbugfinder-work
Copy link
Member Author

drbugfinder-work commented Feb 10, 2024

@SAP/jenkins-library-team

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Feb 11, 2024
Copy link
Contributor

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Apr 12, 2024
@drbugfinder-work
Copy link
Member Author

still open

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Apr 13, 2024
Copy link
Contributor

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Jun 12, 2024
@drbugfinder-work
Copy link
Member Author

@SAP/jenkins-library-team
still open

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Jun 13, 2024
Copy link
Contributor

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Aug 12, 2024
@drbugfinder-work
Copy link
Member Author

@SAP/jenkins-library-team
still open

@github-actions github-actions bot removed the stale marks stale issues and pull requests label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant