-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version during release #46
Comments
For Angular versioning I found this: https://medium.com/@tolvaly.zs/how-to-version-number-angular-6-applications-4436c03a3bd3 For API versioning I found a code snippet like this:
@tiadams what is your opinion on these, I can implement both of these easily if you also think they are OK. |
This seems a bit overkill imo, we also already got the version from the current tag, should be solvable in one line by just editing the file, e.g. via sed. I did it here the other way around (getting the version from the API): |
CURRENT_TAG=$(git describe --tags $(git rev-list --tags --max-count=1))
VERSION=$(echo $CURRENT_TAG | grep -oP "(?<=v\.)[\d\.]+")
ROUTES_FILE="backend/api/routes.py"
PACKAGE_FILE="frontend/package-lock.json"
sed -i "s/version=\"[^\"]*\"/version=\"$VERSION\"/" $ROUTES_FILE
sed -i "s/version=\"[^\"]*\"/version=\"$VERSION\"/" $PACKAGE_FILE Something like this? |
nvm this will not work for package-lock.json, I am looking for a solution. |
Update the versions of API (in routes.py) and PDataViewer (in package-lock.json) automatically during release.
The text was updated successfully, but these errors were encountered: