Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete implementation #15
Autocomplete implementation #15
Changes from 8 commits
c57e5ae
f994497
fa5e7ef
8407f33
a901fde
1569665
b950d81
6779d50
7a2789a
a7eda4a
b75a39b
a315cf6
e28675c
cb269ab
c50e31c
e98b4b7
fb0afc7
b0e92fe
de5d504
71f69aa
68955ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this with the prompt "Dia" for the /autocomplete Endpoint. I get:
This should only return ["Diagnosis", "Diabetes"]. Please adapt this and write a test case for this input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the query is "dia" autocomplete should only return terms that start with dia.
And even if American InDIAn/Alaskan Native contains the term, this should definitely be below Diabetes in terms of similarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably not use fuzzy matching in autocompletion at all, maybe just macth it with a string based regex instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Query "Di" we will get:
Here "diabetes" would not even get suggested to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehmetcanay