Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ii review doesn't support loading AllowlistRules #312

Open
rkm opened this issue Apr 24, 2023 · 2 comments
Open

ii review doesn't support loading AllowlistRules #312

rkm opened this issue Apr 24, 2023 · 2 comments
Assignees

Comments

@rkm
Copy link
Member

rkm commented Apr 24, 2023

This is likely due to a change in how we use the tool, as previously the review tool wasn't used to review FailureStoreReports from file extractions.

$ cat NewRules.yaml
- Action: Ignore
  IfPartPattern: ^ABCD$
$ ./ii review ExampleReport.csv
Unhandled exception. (Line: 2, Col: 3, Idx: 19) - (Line: 2, Col: 16, Idx: 32): Property 'IfPartPattern' not found on type 'IsIdentifiable.Rules.IsIdentifiableRule'.
Aborted

Caused by:

Rules = deserializer.Deserialize<List<IsIdentifiableRule>>(existingRules) ?? new List<IsIdentifiableRule>();

@rkm
Copy link
Member Author

rkm commented Apr 24, 2023

The logging here could also be improved

@jas88
Copy link
Member

jas88 commented Apr 26, 2023

Side effect of this issue in YamlDotNet - aaubry/YamlDotNet#605 - addressed here: aaubry/YamlDotNet#774 - hopefully easily fixable now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants