Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percentages to MongoExtractJobStore log output #1636

Open
rkm opened this issue Sep 25, 2023 · 2 comments
Open

add percentages to MongoExtractJobStore log output #1636

rkm opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rkm
Copy link
Member

rkm commented Sep 25, 2023

This would be useful to see job progress at a glance when following the logs.

Here

Logger.Debug($"Job {jobId} is in state WaitingForCollectionInfo. Expected count is {job.KeyCount}, actual is {collectionInfoCount}");

and here

Logger.Debug($"Job {jobId} is in state WaitingForStatuses. Expected count is {expectedStatusesCount}, actual is {actualStatusCount}");


As aa bonus, we could also display the message rates. This would require adding some timing logic.

@rkm rkm added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2023
@chinmaym07
Copy link

chinmaym07 commented Sep 30, 2023

Hey @rkm ,Can I try working on this ?
Do I need to calculate % on the basis of expectedStatusesCount & actual or is there a utility method to do the same ?

@rkm
Copy link
Member Author

rkm commented Oct 2, 2023

Hi @chinmaym07 ! Feel free to work on this and submit a PR. There is no utility method for this, but the built-in C# functions should suffice. Also consider the number of decimal places that are shown in the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants