Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handling in IsIdentifiable service #1806

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rkm
Copy link
Member

@rkm rkm commented Apr 24, 2024

Proposed Changes

Summarise your proposed changes here, including any notes for reviewers.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

rkm added 3 commits April 24, 2024 17:15
This change allows us to catch all exceptions and choose cases we want
to pass downstream, crashing on all others.

This fixes an issue where IsIdentifiable should have crashed when
encountering a corrupt file instead of sending an ErrorWontRetry
message downstream.
@rkm rkm changed the title Fix/isidentifiable exceptions Fix exception handling in IsIdentifiable service Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.80%. Comparing base (25c8919) to head (a70ba34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
+ Coverage   59.79%   59.80%   +0.01%     
==========================================
  Files         177      177              
  Lines        6332     6334       +2     
  Branches      870      871       +1     
==========================================
+ Hits         3786     3788       +2     
  Misses       2305     2305              
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant