Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception handling in IsIdentifiable service #1806

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix exception handling in IsIdentifiable service #1806

wants to merge 3 commits into from

Commits on Apr 24, 2024

  1. Revert "catch any exception raised during file classification" 

    This reverts commit 6d12e4d.
    @rkm
    rkm committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    74d35d3 View commit details
    Browse the repository at this point in the history

  2. fixup nullability from revert

    @rkm
    rkm committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    73b03a5 View commit details
    Browse the repository at this point in the history

  3. fix exception handling in IsIdentifiableQueueConsumer 

    This change allows us to catch all exceptions and choose cases we want
to pass downstream, crashing on all others.

This fixes an issue where IsIdentifiable should have crashed when
encountering a corrupt file instead of sending an ErrorWontRetry
message downstream.
    @rkm
    rkm committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a70ba34 View commit details
    Browse the repository at this point in the history