Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A request to add a new feature] Blocking the addition of the same input again #7

Open
marciniuk opened this issue Apr 1, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@marciniuk
Copy link

It would be nice if the program blocked the addition of such input that is already in the database. It is also possible that it crashes when we exceed the 90 wishy number without drawing 5* item, but I haven't tested it because it's too big log cleaning.

@SaDiablo
Copy link
Owner

SaDiablo commented Apr 1, 2021

Allowing items being already there is by design, as if you draw 10pull there can be situation like this:

image
And this perfectly valid outcome

If you need you can manually delete single wish from list by pressing right mouse button and Remove
I was thinking about adding some visual grouping to the 10pulls in the future

Also i couldn't reproduce the problem with exceeding 90 wishes without 5* drop - it's simply showing negative numbers and stops showing 5* Rate which allows people to store above real wish limits (for example to quickly calculate character rates to their total by adding dummy wishes or some other creative ways of using it).
image

If you want to test it don't worry about overriding your existing data - saving wishes is manual only :)

@SaDiablo SaDiablo added the enhancement New feature or request label Apr 1, 2021
@marciniuk
Copy link
Author

How about "locking" the draw, for example, so that you can add up to 9x in a row of 3-star elements?

@SaDiablo
Copy link
Owner

SaDiablo commented Apr 10, 2021

Good idea, I'm gonna consider adding it as a part of a validity checks in future. For now I'm trying to rebuild this app in AvaloniaUI - if you wanna see progress check Action artifacts, as I'm open for suggestions :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants