add network foreach cryprto in getPrices #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichri-louay
requested changes
Jul 13, 2023
skanderKha
approved these changes
Jul 21, 2023
web3/wallets.js
Outdated
| }, | ||
| headers: { | ||
| 'X-CMC_PRO_API_KEY': process.env.CMCAPIKEY, | ||
| }, |
There was a problem hiding this comment.
I think it's better to move the options variable in the config file to make cointMarketCap reusiable for futur needs .
HamdiBenK
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear team,
This PR introduces an important update to the cryptoDetails variable by adding the networkSupported and contractAddress fields for each cryptocurrency. The information for these fields will be retrieved using the following API endpoint: https://pro-api.coinmarketcap.com/v2/cryptocurrency/info.
The following changes have been made:
Adding networkSupported and contractAddress Fields: We have enhanced the cryptoDetails variable by including the networkSupported and contractAddress fields for each cryptocurrency. These fields provide information about the supported network and contract address associated with each cryptocurrency. The data for these fields will be fetched from the specified API endpoint.
Reviewers, please ensure that the networkSupported and contractAddress fields have been successfully added to the cryptoDetails variable by fetching the necessary data from the provided API endpoint. Verify that the information is accurate and aligned with the respective cryptocurrencies. Your feedback, suggestions, and alternative approaches to improve the implementation of these additions are highly appreciated.
Thank you for your time and effort in enhancing the functionality and data representation of our platform.
Best regards,
Rania Morheg