Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

graph neural operator #74

Closed
YichengDWu opened this issue Jun 28, 2022 · 9 comments · Fixed by #75
Closed

graph neural operator #74

YichengDWu opened this issue Jun 28, 2022 · 9 comments · Fixed by #75

Comments

@YichengDWu
Copy link
Member

The implemented graph neural operator
image
is not the same one in the original paper
image

Is this intentional?

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 29, 2022

You can check the equation again. In paper, it defines

$$ e(x,y) = [v_t(x), v_t(y)] $$

@YichengDWu
Copy link
Member Author

I only see
image
in the paper Neural Operator: Graph Kernel Network for Partial Differential Equations. Which one are you refering to?

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 29, 2022

I was supposed to think of $a(x)$ as node feature, and it lacks the coordinates here.

@YichengDWu
Copy link
Member Author

$a(x)$ is not the trainable node embeddings but the nontrainable input function. If you are learning the operator from the initial condition to the solution at $t$, then $a(x)=u(0,x)$

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 29, 2022

Good! It can be fixed.

@YichengDWu
Copy link
Member Author

Also note the output of the net is reshaped to be a matrix. It is in fact the NNConv as mentioned in the paper

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 29, 2022

Oh! I also missed this point.

@yuehhua yuehhua mentioned this issue Jun 29, 2022
@yuehhua
Copy link
Collaborator

yuehhua commented Jun 29, 2022

@MilkshakeForReal You can check it if it is right.

@YichengDWu
Copy link
Member Author

It looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants