Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of image_comparison decorator in v0.4.x causes test error. #124

Closed
esc24 opened this issue Oct 29, 2012 · 1 comment
Closed

Use of image_comparison decorator in v0.4.x causes test error. #124

esc24 opened this issue Oct 29, 2012 · 1 comment
Assignees
Milestone

Comments

@esc24
Copy link
Member

esc24 commented Oct 29, 2012

The use of the image_comparison decorator in test_mpl_integration.py causes:

======================================================================
ERROR: Failure: NameError (name 'image_comparison' is not defined)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/sci/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/loader.py", line 390, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/local/sci/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/local/sci/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/net/home/h06/ecamp/cartopy/lib/cartopy/tests/mpl/test_mpl_integration.py", line 189, in <module>
    @image_comparison(baseline_images=['pcolormesh_global_wrap1'])
NameError: name 'image_comparison' is not defined

as the decorator is not imported. I suggest modifying test_mpl_integration.py to use the ImageTesting decorator.

In addition, the image_comparison decorator is imported but not used in the following:

test_image_tiles.py
test_img_nest.py
test_shapely_to_mpl.py
test_caching.py
test_gridliner.py

@pelson
Copy link
Member

pelson commented Oct 29, 2012

Good spot. I wonder how this was working at all...

@esc24 : may I assign you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants