From 5f42b30815bf32eb170822c09161c03858f46fc7 Mon Sep 17 00:00:00 2001 From: Viet Nguyen Duc Date: Sun, 8 Sep 2024 23:26:23 +0000 Subject: [PATCH] update: config basicAuth.enabled is false by default Advanced features will be enabled by user on demand. Fixes: https://github.com/SeleniumHQ/docker-selenium/issues/2285 Signed-off-by: Viet Nguyen Duc --- Makefile | 2 +- README.md | 14 +++++++------- charts/selenium-grid/CONFIGURATION.md | 2 +- charts/selenium-grid/values.yaml | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 4213ebad2..d13563479 100644 --- a/Makefile +++ b/Makefile @@ -13,7 +13,7 @@ NAMESPACE := $(or $(NAMESPACE),$(NAMESPACE),$(NAME)) AUTHORS := $(or $(AUTHORS),$(AUTHORS),SeleniumHQ) PUSH_IMAGE := $(or $(PUSH_IMAGE),$(PUSH_IMAGE),false) FROM_IMAGE_ARGS := --build-arg NAMESPACE=$(NAMESPACE) --build-arg VERSION=$(TAG_VERSION) --build-arg AUTHORS=$(AUTHORS) --sbom=true --attest type=provenance,mode=max -BUILD_ARGS := $(BUILD_ARGS) +BUILD_ARGS := $(BUILD_ARGS) --progress plain MAJOR := $(word 1,$(subst ., ,$(TAG_VERSION))) MINOR := $(word 2,$(subst ., ,$(TAG_VERSION))) MAJOR_MINOR_PATCH := $(word 1,$(subst -, ,$(TAG_VERSION))) diff --git a/README.md b/README.md index 02494e2e9..8f7507ab5 100644 --- a/README.md +++ b/README.md @@ -716,13 +716,13 @@ When using in Dynamic Grid, those variables should be combined with the prefix ` ### Environment variables and default values for upload feature -| Environment variable | Default value | Description | -|-------------------------------|---------------------------------------------|-------------------------------------------------------------------------------------------| -| `SE_UPLOAD_RETAIN_LOCAL_FILE` | `false` | Keep local file after uploading successfully | -| `SE_UPLOAD_COMMAND` | `copy` | RCLONE command is used to transfer file. Enforce `move` when retain local file is `false` | -| `SE_UPLOAD_OPTS` | `-P --cutoff-mode SOFT --metadata--inplace` | Other options belong to RCLONE command can be set. | -| `SE_UPLOAD_CONFIG_FILE_NAME` | `upload.conf` | Config file for remote host instead of set via env variable prefix SE_RCLONE_* | -| `SE_UPLOAD_CONFIG_DIRECTORY` | `/opt/bin` | Directory of config file (change it when conf file in another directory is mounted) | +| Environment variable | Default value | Description | +|-------------------------------|----------------------------------------------|-------------------------------------------------------------------------------------------| +| `SE_UPLOAD_RETAIN_LOCAL_FILE` | `false` | Keep local file after uploading successfully | +| `SE_UPLOAD_COMMAND` | `copy` | RCLONE command is used to transfer file. Enforce `move` when retain local file is `false` | +| `SE_UPLOAD_OPTS` | `-P --cutoff-mode SOFT --metadata --inplace` | Other options belong to RCLONE command can be set. | +| `SE_UPLOAD_CONFIG_FILE_NAME` | `upload.conf` | Config file for remote host instead of set via env variable prefix SE_RCLONE_* | +| `SE_UPLOAD_CONFIG_DIRECTORY` | `/opt/bin` | Directory of config file (change it when conf file in another directory is mounted) | ___ diff --git a/charts/selenium-grid/CONFIGURATION.md b/charts/selenium-grid/CONFIGURATION.md index f88bf8722..9b050432f 100644 --- a/charts/selenium-grid/CONFIGURATION.md +++ b/charts/selenium-grid/CONFIGURATION.md @@ -66,7 +66,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes | tls.disableHostnameVerification | bool | `true` | Disable verification the hostname included in the server's TLS/SSL certificates matches the hostnames provided | | registrationSecret.enabled | bool | `false` | Enable feature node registration secret to make sure that the node is one you control and not a rouge node | | registrationSecret.value | string | `"HappyTesting"` | The secret value to be used for node registration | -| basicAuth.enabled | bool | `true` | Enable or disable basic auth for the Hub/Router | +| basicAuth.enabled | bool | `false` | Enable or disable basic auth for the Hub/Router | | basicAuth.username | string | `"admin"` | Username for basic auth | | basicAuth.password | string | `"admin"` | Password for basic auth | | isolateComponents | bool | `false` | Deploy Router, Distributor, EventBus, SessionMap and Nodes separately | diff --git a/charts/selenium-grid/values.yaml b/charts/selenium-grid/values.yaml index 63fd28d12..656cbbcfe 100644 --- a/charts/selenium-grid/values.yaml +++ b/charts/selenium-grid/values.yaml @@ -104,7 +104,7 @@ registrationSecret: # Basic auth settings for Selenium Grid basicAuth: # -- Enable or disable basic auth for the Hub/Router - enabled: true + enabled: false # -- Username for basic auth username: admin # -- Password for basic auth