Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Wrong Version Numbering for breaking changes #12241

Closed
principat opened this issue Jun 22, 2023 · 4 comments
Closed

[🐛 Bug]: Wrong Version Numbering for breaking changes #12241

principat opened this issue Jun 22, 2023 · 4 comments
Labels
I-question Applied to questions. Issues should be closed and send the user to community resources.

Comments

@principat
Copy link

principat commented Jun 22, 2023

What happened?

I updated form Selenium Version 4.0.0 to 4.10. By the Version numbering there should be no problems because there are only minor changes like new features, deprecation-Warnings and bugfixes. There are no changes in the API.

But when upgrading from 4.0.0 to 4.10.0 there are some breaking changes at selenium.webdriver.Chrome. Some of the arguments for the constructor are removed.

removing external functions, classes... or changing their signature should be marked as breaking change and lead to an increase of the major-part of the version

How can we reproduce the issue?

  • in 4.0.0 use the following code to initialize the chrome-Driver
    selenium.webdriver.Chrome('path to the chrome-driver', options=selenium.webdriver.ChromeOptions())
  • upgrade to 4.10.0 and you will get an error, that options are defined twice

Relevant log output

none

Operating System

Windows

Selenium version

Python 4.0.0

What are the browser(s) and version(s) where you see this issue?

Chorme any version

What are the browser driver(s) and version(s) where you see this issue?

Chrome any version

Are you using Selenium Grid?

no

@github-actions
Copy link

@principat, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@principat principat changed the title [🐛 Bug]: Wrong Version Numbering for breking changes [🐛 Bug]: Wrong Version Numbering for breaking changes Jun 22, 2023
@diemol
Copy link
Member

diemol commented Jun 22, 2023

We do not follow semver. For breaking changes we deprecate the code and wait at least two minor releases before removing it or making the change. For example, the code you are referencing has been deprecated since 4.0.0, and was removed in 4.10.0. Users had 1.5 years to change their code.

If you have more questions, I will leave some links below where you can join our chat.

@diemol diemol added I-question Applied to questions. Issues should be closed and send the user to community resources. and removed I-defect needs-triaging labels Jun 22, 2023
@github-actions
Copy link

💬 Please ask questions at:

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I-question Applied to questions. Issues should be closed and send the user to community resources.
Projects
None yet
Development

No branches or pull requests

2 participants