From 661c70563120efe8d9b3bf70afa29328e6e4ffe0 Mon Sep 17 00:00:00 2001 From: Levi Thomason Date: Mon, 7 Nov 2016 11:10:42 -0800 Subject: [PATCH] feat(DropdownItem): callback with (e, props) onClick (#805) breaking(DropdownItem): callback with (e, props) onClick --- src/modules/Dropdown/Dropdown.js | 4 ++-- src/modules/Dropdown/DropdownItem.js | 6 +++--- test/specs/modules/Dropdown/DropdownItem-test.js | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/modules/Dropdown/Dropdown.js b/src/modules/Dropdown/Dropdown.js index 5267db2089..202405022a 100644 --- a/src/modules/Dropdown/Dropdown.js +++ b/src/modules/Dropdown/Dropdown.js @@ -149,7 +149,7 @@ export default class Dropdown extends Component { /** Called when a close event happens */ onClose: PropTypes.func, - /** Called when an open event happens */ + /** Called when an open event happens */ onOpen: PropTypes.func, /** Called with the React Synthetic Event and current value on search input change. */ @@ -513,7 +513,7 @@ export default class Dropdown extends Component { this.toggle(e) } - handleItemClick = (e, value) => { + handleItemClick = (e, { value }) => { debug('handleItemClick()') debug(value) const { multiple, name, onAddItem, options } = this.props diff --git a/src/modules/Dropdown/DropdownItem.js b/src/modules/Dropdown/DropdownItem.js index fb2747f673..5b272f2a17 100644 --- a/src/modules/Dropdown/DropdownItem.js +++ b/src/modules/Dropdown/DropdownItem.js @@ -65,7 +65,7 @@ export default class DropdownItem extends Component { PropTypes.string, ]), - /** Called on click with (event, value, text). */ + /** Called on click with (event, props). */ onClick: PropTypes.func, } @@ -76,9 +76,9 @@ export default class DropdownItem extends Component { } handleClick = (e) => { - const { onClick, value } = this.props + const { onClick } = this.props - if (onClick) onClick(e, value) + if (onClick) onClick(e, this.props) } render() { diff --git a/test/specs/modules/Dropdown/DropdownItem-test.js b/test/specs/modules/Dropdown/DropdownItem-test.js index 12fac72795..15902a1538 100644 --- a/test/specs/modules/Dropdown/DropdownItem-test.js +++ b/test/specs/modules/Dropdown/DropdownItem-test.js @@ -54,18 +54,18 @@ describe('DropdownItem', () => { expect(click).to.not.throw() }) - it('is called with (e, value) when clicked', () => { + it('is called with (e, props) when clicked', () => { const spy = sandbox.spy() const value = faker.hacker.phrase() const event = { target: null } - const props = { value } + const props = { value, foo: 'bar' } shallow() .simulate('click', event) spy.should.have.been.calledOnce() - spy.should.have.been.calledWithMatch(event, value) + spy.should.have.been.calledWithMatch(event, props) }) }) })