Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples importing ../common cannot be edited #1037

Closed
levithomason opened this issue Dec 16, 2016 · 1 comment
Closed

Examples importing ../common cannot be edited #1037

levithomason opened this issue Dec 16, 2016 · 1 comment
Labels
docs good first issue help wanted

Comments

@levithomason
Copy link
Member

Steps

Try to change a Dropdown example on the doc site that imports '../common', such as selection.

Expected Result

The example should live update.

Actual Result

An error is thrown.

This is because there is special handling involved to make import "work" in a browser. The file ../common is not part of this special handling.

The common module needs to imported in similar fashion to the other modules that are importable from the doc examples. This is done here in ComponentExample.js.

Version

0.62.0

Testcase

http://react.semantic-ui.com/modules/dropdown#selection
@levithomason
Copy link
Member Author

Fixed in #1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levithomason