Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Dimmer component doesn't exist. #1091

Closed
wcatron opened this issue Dec 28, 2016 · 3 comments
Closed

Typescript: Dimmer component doesn't exist. #1091

wcatron opened this issue Dec 28, 2016 · 3 comments

Comments

@wcatron
Copy link
Contributor

wcatron commented Dec 28, 2016

Currently typescript throws "module has no exported member Dimmer" sure enough in the typescript declaration file between Checkbox and Dropdown (which are before and after Dimmer in the docs) there is no Dimmer component.

export class Checkbox extends React.Component<CheckboxProps, {}> {
}

// Dimmer missing here.

// Dropdown
// ----------------------------------

I can work on a PR (I have to regardless) unless there's a typical person whose good at creating them by hand.

@levithomason
Copy link
Member

Closed by #1092

@IsaackRasmussen
Copy link

IsaackRasmussen commented Dec 30, 2016

Hi,

I just upgraded to 0.63.3 hoping it would fix this error:
error TS2324: Property 'dimmer' is missing in type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<ImageProps, ComponentState>> & { childre...'.

But that's perhaps a different issue?

I get it when I try to use Image

Update: I got it working with this workaround {...{dimmer: ""}}
From this other issue that seems similar: #698

@wcatron
Copy link
Contributor Author

wcatron commented Dec 30, 2016

@IsaackRasmussen Yes that is a different issue. This issue was about the Dimmer component not the dimmer property.

The {...{}} is unfortunately a common work around we have to use when using the as property otherwise you shouldn't have to use it. I don't think #698 is the same problem you're having. You may want to open a new issue for adding the dimmer property to the Image component typescript definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants