Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Popup): rename positioning to position #1259

Closed
levithomason opened this issue Jan 31, 2017 · 4 comments
Closed

breaking(Popup): rename positioning to position #1259

levithomason opened this issue Jan 31, 2017 · 4 comments

Comments

@levithomason
Copy link
Member

Many components currently accept a position prop. The Popup, however, calls this prop positioning. We should update the Popup prop positioning to be position.

This new prop name needs to be updated in:

  • the component
  • tests
  • doc site usages

Since the old prop will no longer work, this will be a breaking change and ship with the next minor bump of the library (since we are pre 1.0).

@tarang9211
Copy link
Contributor

@levithomason I'll pick this up.

@tarang9211
Copy link
Contributor

@levithomason I thought I was picking this one up?

@levithomason
Copy link
Member Author

I'd take this up with @kamdz. I have no control over who does what since it is open source. Perhaps open your PR immediately after you begin work on the issue, as well as leave a comment.

That said, all PRs are gladly accepted from anyone who submits them :) I surely don't want to hinder folks from contributing.

@levithomason
Copy link
Member Author

Merged in #1342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants