You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many components currently accept a position prop. The Popup, however, calls this prop positioning. We should update the Popup prop positioning to be position.
This new prop name needs to be updated in:
the component
tests
doc site usages
Since the old prop will no longer work, this will be a breaking change and ship with the next minor bump of the library (since we are pre 1.0).
The text was updated successfully, but these errors were encountered:
I'd take this up with @kamdz. I have no control over who does what since it is open source. Perhaps open your PR immediately after you begin work on the issue, as well as leave a comment.
That said, all PRs are gladly accepted from anyone who submits them :) I surely don't want to hinder folks from contributing.
Many components currently accept a
position
prop. ThePopup
, however, calls this proppositioning
. We should update the Popup proppositioning
to beposition
.This new prop name needs to be updated in:
Since the old prop will no longer work, this will be a breaking change and ship with the next minor bump of the library (since we are pre 1.0).
The text was updated successfully, but these errors were encountered: