Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Confirm): use shorthands for content and buttons definition #1290

Closed
lemol opened this issue Feb 6, 2017 · 1 comment
Closed

feat(Confirm): use shorthands for content and buttons definition #1290

lemol opened this issue Feb 6, 2017 · 1 comment
Labels
enhancement

Comments

@lemol
Copy link

lemol commented Feb 6, 2017

Steps

  1. Render the Confirm addon with a content that is an object: <Confirm content={<b>hi!</b>} {...rest} />

Expected Result

It should be rendered without any warning.

Actual Result

It renders correctly, but gives a warning: content prop have to be a string.

See src/addons/Confirm/Confirm.js#L53
@layershifter
Copy link
Member

@lemol Thanks for report. However, I've made #1282 for it yesterday.

@layershifter layershifter mentioned this issue Feb 6, 2017
Merged
@layershifter layershifter changed the title Content prop of Confirm addon don't need to be a string feat(Confirm): use shorthands for content and buttons Feb 6, 2017
@layershifter layershifter changed the title feat(Confirm): use shorthands for content and buttons feat(Confirm): use shorthands for content and buttons definition Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemol @layershifter