Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form.Input not honouring autoCapitalize prop #1312

Closed
flipvrijn opened this issue Feb 13, 2017 · 1 comment · Fixed by #1318
Closed

Form.Input not honouring autoCapitalize prop #1312

flipvrijn opened this issue Feb 13, 2017 · 1 comment · Fixed by #1318
Labels
enhancement good first issue help wanted

Comments

@flipvrijn
Copy link
Contributor

flipvrijn commented Feb 13, 2017 •
edited
Loading

Steps

  1. Use Form.Input component with autoCapitalize="none".

Expected Result

It should be render an input element with the autocapitalize="none" attribute.

Actual Result

It omits the autocapitalize attribute.

Version

0.64.8

Testcase

Fork this to show the issue: http://codepen.io/anon/pen/wgRxMZ
@levithomason
Copy link
Member

The fix here is extremely simple, the prop just needs to be added to whitelist of HTML input props:

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/elements/Input/Input.js#L20

Great way to get a first contribution :)

@flipvrijn flipvrijn mentioned this issue Feb 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Input): add autoCapitalize to html input props flipvrijn/Semantic-UI-React
2 participants
@flipvrijn @levithomason