You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "input" property suggests it could somehow be set to make the component fill its container. But it's unclear what that setting would be (), and I don't see it doing anything in the code either.
What I want
The existing "fluid" property () makes the search results fill the container, not the input field itself. That's an inconsistent meaning for the property "fluid", which is used in other components to make the component itself fill the width of its container. I propose that make the component fill its container's width, and make the search results fill it's container width. That's more consistent and clearer to use.
Possible solution
It seems that a Search component property (like repurposing "fluid") just needs to be passed as the Input property "fluid" in the renderSearchInput function.
Version
2.2.2
The text was updated successfully, but these errors were encountered:
Thanks for the suggestion on the backticks. I'm glad there's an existing solution for this. I'd suggest updating the documentation for the Search component's input property to make this clearer -- something like: "Pass properties to the input component (e.g. input={{ fluid: true }})"
The problem
The "input" property suggests it could somehow be set to make the component fill its container. But it's unclear what that setting would be (), and I don't see it doing anything in the code either.
What I want
The existing "fluid" property () makes the search results fill the container, not the input field itself. That's an inconsistent meaning for the property "fluid", which is used in other components to make the component itself fill the width of its container. I propose that make the component fill its container's width, and make the search results fill it's container width. That's more consistent and clearer to use.
Possible solution
It seems that a Search component property (like repurposing "fluid") just needs to be passed as the Input property "fluid" in the renderSearchInput function.
Version
2.2.2
The text was updated successfully, but these errors were encountered: