Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings #1440

Closed
edmundtfy opened this issue Mar 11, 2017 · 1 comment
Closed

Typings #1440

edmundtfy opened this issue Mar 11, 2017 · 1 comment
Labels

Comments

@edmundtfy
Copy link

Steps

  1. Install semantic-ui-react to my existing react project, got version 0.67.0
  2. import form in semantic-ui-react
    Additional info. I'm using the same React boilerplate with my other project, and was using 0.63.6 and the typings are all there

Expected Result

Typings should be there, including onSubmit, placeholder etc

Actual Result

So far, I cannot see onSubmit, placeholder

Version

0.67.0

Testcase

My Package.json in this current project

"ava": {
    "require": [
      "babel-register"
    ],
    "babel": "inherit"
  },
  "scripts": {
    "start": "npm run watch",
    "watch": "gulp watch",
    "build": "gulp build",
    "deploy": "gulp deploy",
    "test": "ava --tap | tap-nyan"
  },
  "author": "Maurizio Mangione",
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/Granze/react-starterify/issues"
  },
  "homepage": "https://github.com/Granze/react-starterify",
  "dependencies": {
    "history": "^3.0.0",
    "react": "^15.0.1",
    "react-bootstrap": "^0.30.6",
    "react-dom": "^15.0.1",
    "react-loading": "0.0.9",
    "react-router": "^2.3.0",
    "react-timeago": "^3.1.3",
    "rxjs": "^5.0.3",
    "whatwg-fetch": "^2.0.1"
  },
  "devDependencies": {
    "autoprefixer": "^6.3.6",
    "ava": "^0.15.2",
    "babel": "^6.5.2",
    "babel-core": "^6.7.7",
    "babel-eslint": "^6.0.4",
    "babel-preset-es2015": "^6.6.0",
    "babel-preset-react": "^6.5.0",
    "babel-register": "^6.7.2",
    "babelify": "^7.3.0",
    "browser-sync": "^2.12.5",
    "browserify": "^13.0.0",
    "cssnano": "^3.5.2",
    "eslint": "^2.8.0",
    "eslint-config-airbnb": "^9.0.1",
    "eslint-plugin-import": "^1.6.0",
    "eslint-plugin-jsx-a11y": "^1.0.3",
    "eslint-plugin-react": "^5.0.1",
    "gulp": "^3.9.1",
    "gulp-eslint": "^2.0.0",
    "gulp-gh-pages": "^0.5.4",
    "gulp-html-replace": "^1.5.5",
    "gulp-imagemin": "^3.0.1",
    "gulp-notify": "^2.2.0",
    "gulp-plumber": "^1.1.0",
    "gulp-postcss": "^6.1.0",
    "gulp-rename": "^1.2.2",
    "gulp-sass": "^3.1.0",
    "gulp-sourcemaps": "^2.0.0-alpha",
    "gulp-strip-debug": "^1.1.0",
    "gulp-uglify": "^1.5.3",
    "imagemin-pngquant": "^5.0.0",
    "lodash": "^4.11.1",
    "postcss-nested": "^1.0.0",
    "postcss-simple-extend": "^1.0.0",
    "postcss-simple-vars": "^2.0.0",
    "react": "^15.4.2",
    "react-addons-test-utils": "^15.0.1",
    "react-dom": "^15.4.2",
    "react-router": "^2.8.1",
    "rimraf": "^2.5.2",
    "run-sequence": "^1.1.5",
    "tap-nyan
```": "0.0.2",
    "vinyl-buffer": "^1.0.0",
    "vinyl-source-stream": "^1.1.0",
    "watchify": "^3.7.0"
  }

Snippet of code in .js file

import { Form, Button, Input, Dropdown } from 'semantic-ui-react';
...
<Form loading={this.state.loading} onSubmit={/* <--does not show up*/}> 
        <Form.Group>
          <Form.Input label="Title" type="text" />
          <Form.Input label="Description" type="text" />
          <Input label="" placeholder="" />
          <Form.Group>
          </Form.Group>
          <Input
            label={<Dropdown defaultValue=".com" options={salaryOptions} />}
            labelPosition="left"
            placeholder={/* <--does not show up*/}
          />
        </Form.Group>
        <Button typ />
      </Form>
@layershifter
Copy link
Member

In 0.67.0 we removed selializer functionality from Form component (#1367). So, onSubmit prop was removed too. We define only components' props in typings, see #1072.

However, you can still use onSubmit on Form and placeholder on Input (#1072).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants