Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings on PropTypes with React >= 15.5.0 #1587

Closed
robgietema opened this issue Apr 16, 2017 · 1 comment
Closed

Deprecation warnings on PropTypes with React >= 15.5.0 #1587

robgietema opened this issue Apr 16, 2017 · 1 comment

Comments

@robgietema
Copy link

robgietema commented Apr 16, 2017 •
edited
Loading

As of React 15.5.0 PropTypes should be imported from the prop-types package and not from the main React package anymore (see: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html).

Steps

Render any component which uses PropTypes.

Expected Result

No deprecation warnings.

Actual Result

Deprecation warnings.

Version

0.68.0

Testcase

http://codepen.io/anon/pen/dWoJOM
@g1eny0ung
Copy link
Contributor

g1eny0ung commented Apr 17, 2017 •
edited
Loading

Is the Dropdown give a warning? I open a pr #1588

@g1eny0ung g1eny0ung mentioned this issue Apr 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robgietema @g1eny0ung