Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown - arrow keys don't work with Dropdown search in menu example #1597

Closed
GregoryPotdevin opened this issue Apr 18, 2017 · 3 comments
Closed

Comments

@GregoryPotdevin
Copy link

Steps

Expected Result

Dropdown items should be selected when using the arrow keys

Actual Result

Selection using the arrow keys doesn't work, and an error is output in the console :

image

Version

0.67.2

Testcase

http://codepen.io/GregoryPotdevin/full/GmpOQR/

Cause

Using the arrow keys in a dropdown triggers Dropdown.moveSelectionBy, which fails because there are no options.

Seems non trivial to fix as the dropdown needs to manage its own items for this to work. Might require to add specific code for a "searchable dropdown" (that would use the dropdown menu options logic, but would render both a search input and a title label)

@levithomason
Copy link
Member

Duplicate #958, #889

Please note the message above this and several other Dropdown examples:

image

It is indeed non-trivial, hence the long running issue here. First step is to get Menu shorthand in place and replicate it for the Dropdown.Menu, see #1365 for more on this.

@GregoryPotdevin
Copy link
Author

Sorry for the duplicate, not sure how I missed the warning (even though I saw it for other Dropdown features).

@levithomason
Copy link
Member

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants