Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal closeIcon is invisible with dimmer='inverted' #1838

Closed
radix opened this issue Jul 6, 2017 · 2 comments
Closed

Modal closeIcon is invisible with dimmer='inverted' #1838

radix opened this issue Jul 6, 2017 · 2 comments

Comments

@radix
Copy link

radix commented Jul 6, 2017

Hey semantic-ui-react maintainers! Thanks for the great library, I've been using it to great effect. I'm having a minor issue with Modals with close icons, though. I'm using inverted-dimmer modals so that the dimmer is white instead of black. I recently tried adding a closeIcon to these modals but I couldn't see it, because it seems to be rendering with a white font. It seems like if you're using a dimmer='inverted' and closeIcon, it should probably default to swapping the color of the close icon so it's visible?

I'm not sure if this is strictly a CSS issue since it seems like it only comes about through certain combination of features that semantic-ui-react uses together in the <Modal /> component. But if it is, please let me know and I can file a ticket in the CSS repo.

Steps

<Modal dimmer='inverted' closeIcon="close" header="Hello" content="Content" />

Expected Result

Visible close icon

Actual Result

Invisible close icon (white on white)

Version

semantic-ui-react 0.70.0
semantic-ui-css 2.2.10

Testcase

https://codepen.io/anon/pen/GEBjpG

@radix
Copy link
Author

radix commented Jul 6, 2017

I'm sorry, I guess it is just a CSS issue. I found it here: Semantic-Org/Semantic-UI#3070

@radix radix closed this as completed Jul 6, 2017
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants