Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allowAdditions option for Dropdowns #276

Closed
levithomason opened this issue Jun 23, 2016 · 4 comments
Closed

Support allowAdditions option for Dropdowns #276

levithomason opened this issue Jun 23, 2016 · 4 comments

Comments

@levithomason
Copy link
Member

We're currently using this feature in one of our forms:

http://semantic-ui.com/modules/dropdown.html#tagging-and-user-additions

We cannot finish updating and removing previous hacks until we add support for this or rework the form to not rely on it.

@levithomason
Copy link
Member Author

Our single use of this feature is no longer needed, we've opted to forgo it's development for now.

@dylankiss
Copy link
Contributor

I need the allowAdditions functionality for our project and have added this on my fork of stardust. When I clean it up, I will make a PR such that you could take a look whether I took a good approach or not.

@levithomason
Copy link
Member Author

@dylankiss I would be delighted to take a look. Feel free to open the PR now, we can collaborate on it there. I am traveling today but will be back tomorrow. Cheers!

@dylankiss
Copy link
Contributor

@levithomason I opened a PR (https://github.com/TechnologyAdvice/stardust/pull/356) such that you can take a look. I still need to add tests when everything seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants