Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal - unknown prop 'settings' #354

Closed
ljubic opened this issue Aug 1, 2016 · 2 comments
Closed

Modal - unknown prop 'settings' #354

ljubic opened this issue Aug 1, 2016 · 2 comments
Labels

Comments

@ljubic
Copy link

ljubic commented Aug 1, 2016

According to Stardust documentation Modal has property 'settings', but when I add it to the component it throws me an error that property is unknown.

Here is the code:

<Modal settings={{"observeChanges": true}}>
     /* other code... */
</Modal>

Is there any solution to this? Modal is also not centered vertically.

@levithomason
Copy link
Member

@ljubic the modal is soon to be updated to our v1 component API, see https://github.com/TechnologyAdvice/stardust/issues/269. We'll likely attack this component soon since we also need it here at @TechnologyAdvice.

If you'd like to use it anyway, while it is in development, let me know your use case and I'll see if I can help.

To be future proof, I'd avoid using the settings prop and wrap it as a controlled component. Once it is updated, we'll support both controlled and uncontrolled versions as we do with all our modules.

Thanks much.

@levithomason
Copy link
Member

Closing for now in light of the thumbs up. Let me know if there are any further issues on this that we can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants