Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Doc website prevents the use of cmd + c #425

Closed
besh opened this issue Aug 23, 2016 · 3 comments
Closed

Bug: Doc website prevents the use of cmd + c #425

besh opened this issue Aug 23, 2016 · 3 comments

Comments

@besh
Copy link

besh commented Aug 23, 2016

When attempting to do cmd + c to copy code snippets (or anything) focus is set to the search bar. This is because of https://github.com/TechnologyAdvice/stardust/blob/master/docs/app/Components/Sidebar/Sidebar.js#L38. A catch is needed to prevent focus from firing when cmd (and likely ctrl) keycodes are captured.

For now, right-clicking and selecting "copy" still works though!

I attempted to fix this but after cloning, npm installing, and running npm start, nothing shows up on localhost:8080 for me. I'll revisit if I get a chance. I may have done something stupid on setup. There's a lot of npm scripts and maybe others have to be run before I can dev on the doc site but that wasn't immediately apparent to me. If someone wants to point out what I did incorrectly, I would be happy to fix this bug!

@levithomason
Copy link
Member

levithomason commented Aug 23, 2016

Should deploy in ~5m, thanks for the report!

@levithomason
Copy link
Member

Deployed, though affected by #423. So there may be intermittent doc site availability for the time being.

@besh
Copy link
Author

besh commented Aug 23, 2016

Super fast response! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants