Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Header): subheader and image shorthand #511

Closed
levithomason opened this issue Sep 19, 2016 · 1 comment
Closed

fix(Header): subheader and image shorthand #511

levithomason opened this issue Sep 19, 2016 · 1 comment
Assignees

Comments

@levithomason
Copy link
Member

The Header icon/image requires the content div. The content div should contain all text.

Image

The image shorthand currently does not wrap the content shorthand in HeaderContent.

Subheader

Header subheaders should be rendered as HeaderContent children. Currently, the subheader shorthand is rendered as a sibling when there is an icon/image. Example here only shows an icon, but the issue exists for subheaders when there is an icon or an image.

<Header icon='user' content='foo' subheader='bar' />

Outputs:

<div class="ui header">
  <i class="user icon"></i>
  <div class="content">foo</div>
  <div class="sub header">bar</div>
</div>

It should output:

<div class="ui header">
  <i class="user icon"></i>
  <div class="content">
    foo
    <div class="sub header">bar</div>
  </div>
</div>
@levithomason
Copy link
Member Author

I've marked this help wanted, but I actually need it now. PR coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant