Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labeled icon <Button /> not rendered as <button> #596

Closed
Chris-R3 opened this issue Oct 3, 2016 · 3 comments
Closed

labeled icon <Button /> not rendered as <button> #596

Chris-R3 opened this issue Oct 3, 2016 · 3 comments
Labels

Comments

@Chris-R3
Copy link
Contributor

Chris-R3 commented Oct 3, 2016

Steps to Reproduce

I'd like to render a labeled icon button with type='submit' with following jsx code:

<Button type='submit' icon='save' labeled content='save' />

Expected Behavior

<button class="ui labeled icon button" type="submit">
  <i class="save icon"></i>
  save
</button>

Actual Behavior

<div type="submit" class="ui labeled icon button" tabindex="0">
  <i class="save icon"></i>
  save
</div>

Test Case

http://codepen.io/Chlris-R3/pen/xEXBzK?editors=0010

Is this a bug or do I need to change my code somehow? I also tried adding as='button' with the same result.

@levithomason
Copy link
Member

levithomason commented Oct 3, 2016

Confirmed bug, thanks much. @yesmin is preparing the fix in #597.

@Chris-R3
Copy link
Contributor Author

Chris-R3 commented Oct 3, 2016

much appreciated
keep up the good work ❤️

@levithomason
Copy link
Member

Fixed in #597 and released in stardust@0.52.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants