Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup redundancy in tests #60

Closed
levithomason opened this issue Oct 16, 2015 · 0 comments
Closed

Cleanup redundancy in tests #60

levithomason opened this issue Oct 16, 2015 · 0 comments

Comments

@levithomason
Copy link
Member

There is a lot of redundancy in tests. Mostly, findFoo() calls serve both query and assertion purposes. These are equivalent:

let gridClassName = render(<Grid />).findClass('sd-grid').props.className;
gridClassName.should.contain('sd-grid');
render(<Grid />).findClass('sd-grid');

Update all tests to remove their redundant assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant