IE Modal error

[mclarentgp]

I'm receiving the following error when I close the modal window through a button click event in IE.

"Unable to get property 'contains' of undefined or null reference"

I do not receive any error if i close the modal by clicking outside of it though.
I'm using the latest version of semantic-ui-react and my version of IE is Version 11.0.9600.18500

[levithomason]

We use Node.contains() in a couple places. We may need to replace this with a util. Can you paste the full error output including any stack trace?

[mclarentgp]

I'm not seeing any stack trace on my end and the most i can see if that were its erroring out in IE is the specific line,
// If event happened in the portal, ignore it

  if (_this.portal.contains(e.target)) return;

in portal.js

[mclarentgp]

I turned the debugger on in the console for the modal and see that the error occurs after this.

semanticUIReact:modal handlePortalUnmount()

[levithomason]

Thanks much, this is enough for us to fix it 👍.

Whoever picks this up, we need to remove use of Node.contains(). Instead, let's add this util:

/**
 * Returns true if a root node contains another node.
 * @param {DOMElement} root The root that is expected to contain the node
 * @param {DOMElement} node The node to look for in root
 * @returns {boolean} Whether or not root contains the node
 */
export const rootContainsNode(root, node) {
  // traverse node parents, if we reach the root then the node was in root
  while (node) {
    if (node === root) return true
    node = node.parentNode
  }

  return false
}

[jeffcarbs]

"Unable to get property 'contains' of undefined or null reference"

@levithomason - I think the issue raised here is that this.portal is undefined, not that contains isn't a function.

The issue may be with firstElementChild although it seems to be supported on all modern browsers. It's used to set the portal here: https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/addons/Portal/Portal.js#L333

FWIW Node.contains has been supported in IE dating back to v5 😮 : https://developer.mozilla.org/en-US/docs/Web/API/Node/contains

[levithomason]

Thanks, I looked right over this in the OP: ...property 'contains' of undefined....

From a quick scan around the web, it looks like the fix may be as simple as:

-this.portal = this.node.firstElementChild
+this.portal = this.node.children[0]

[layershifter]

I'll test it on windows PC today, if last comment solves problem, I'll make PR.

[layershifter]

Docs has problems with running in IE 11, I'm reviewing them, but main problem is not in firstElementChild - it's supported from IE9. Looks like problem with unmounting, but I haven't enough time today to find problem.

[levithomason]

Looks like problem with unmounting

The OP noted this error Unable to get property 'contains' of undefined or null reference. Which problem are you referring to as I do not see any errors on your console in the screenshot provided?

[layershifter]

It's output of console.log(this.portal) after line this.portal = this.node.firstElementChild.

---

I've added some debug to Portal.handleDocumentClick.

+ debug('handleDocumentClick(): start')
// If event happened in the portal, ignore it
if (this.portal.contains(e.target)) return

And recieved this in IE:

While in Chrome:

---

If we look on IE debug, it becomes clear that problem is in event calling, not in firstElementChild. There is this.portal = null in unmountPortal, so fail on contains() is resonable, this.portal is null.

So, main question there is why IE calls handleDocumentClick when it was removed in unmountPortal 😕

[levithomason]

Ah, I see. I may have to drag out the old windows box at some point to debug. It would also be good to get some tests going in multiple browsers / platforms. I'll add these to my bucket list, won't be soon though!

[layershifter]

@levithomason As temporary fix we can make this change:

+ // Temporary fix for IE
+ if(!this.portal) return

// If event happened in the portal, ignore it
if (this.portal.contains(e.target)) return

[levithomason]

I've made some updates and added your suggestion, see #823.

[layershifter]

I'll pull branch with fix and test it IE today.

[EwanValentine]

Modals aren't working for me in I.E. 11, it shows the dimmed background, then no actual modal.

[levithomason]

Please open a new issue and include as much information as possible. There is a template shown when you create an issue.