You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The defaultActiveIndex is overridden in the Accordion on componentWillMount. This is an edge case, but we need to update the AutoControlledComponent to defer to default props when calling trySetState in componentWillMount.
The real solve here is likely adding static defaultAutoControlledProps. Currently, the AutoControlledComponent tells devs to use trySetState in componentWillMount instead of setting defaults for auto controlled props. This is to prevent the actual defaults from always winning, however, if we had our own auto controlled defaults then we could apply them correctly.
The text was updated successfully, but these errors were encountered:
This was fixed for the Accordion but likely exists in other auto controlled components.
From #763:
The
defaultActiveIndex
is overridden in the Accordion oncomponentWillMount
. This is an edge case, but we need to update theAutoControlledComponent
to defer to default props when callingtrySetState
incomponentWillMount
.The real solve here is likely adding
static defaultAutoControlledProps
. Currently, theAutoControlledComponent
tells devs to usetrySetState
incomponentWillMount
instead of setting defaults for auto controlled props. This is to prevent the actual defaults from always winning, however, if we had our own auto controlled defaults then we could apply them correctly.The text was updated successfully, but these errors were encountered: