Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle <Button disabled /> #929

Closed
jeffcarbs opened this issue Nov 23, 2016 · 0 comments
Closed

Better handle <Button disabled /> #929

jeffcarbs opened this issue Nov 23, 2016 · 0 comments

Comments

@jeffcarbs
Copy link
Member

Similar issue to #791

By default, setting a button to disabled only disables pointer events. You can still tab-focus and press enter to "click" it. We should prevent clicks (both mouse clicks and enter) on disabled Button within the component itself.

Also, like the Dropdown issue, there's no way to show a popup on a disabled Button (which I'd imagine is a very common use-case, letting the user know why the button is disabled). I don't think we should manually set the pointer-events, but we should make it possible for the user to do so while still keeping the "disabled" behavior of preventing the default action.

See the following codepen for examples: http://codepen.io/jeffcarbs/pen/gLWBRj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant