Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript eslint type checking errors #3690

Open
DukeManh opened this issue Oct 6, 2022 · 2 comments
Open

Fix typescript eslint type checking errors #3690

DukeManh opened this issue Oct 6, 2022 · 2 comments
Assignees
Labels
type: bug Something isn't working

Comments

@DukeManh
Copy link
Contributor

DukeManh commented Oct 6, 2022

What happened:
When I was working on #3683, I realized typescript-eslint and recommended-requiring-type-checking config is not extended in src/web/app eslint config which made us miss quite a few of the lint errors.

We need to fix these errors with the updated config.

module.exports = {
  extends: [
    '@senecacdot/eslint-config-telescope',
++    'plugin:@typescript-eslint/recommended',
++    'plugin:@typescript-eslint/recommended-requiring-type-checking',
  ],
...
  parserOptions: {
    ecmaFeatures: {
      jsx: true,
    },
    ecmaVersion: 2021,
++    project: './tsconfig.json',
++    tsconfigRootDir: './',
  },

...
};

image

What should have happened:

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@DukeManh DukeManh added the type: bug Something isn't working label Oct 6, 2022
@humphd
Copy link
Contributor

humphd commented Oct 6, 2022

This would be a great issue for someone to work on for Hacktoberfest, or to pick one of the files it reports and fix errors in that.

@cindyorangis
Copy link
Contributor

I think this issue is quite involved and touches more than 30+ files, so I'll assign myself here.

@cindyorangis cindyorangis self-assigned this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants