Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toxics are not set when creating a proxy for the first time. #79

Open
jpittis opened this issue Aug 28, 2015 · 2 comments
Open

Toxics are not set when creating a proxy for the first time. #79

jpittis opened this issue Aug 28, 2015 · 2 comments

Comments

@jpittis
Copy link
Contributor

jpittis commented Aug 28, 2015

When using the Go client as follows, toxics are not added to a proxy.
Given var p []toxiproxy.Proxy with toxics.

proxy := client.NewProxy(&p)
proxy.Create()

This does not properly add the configured toxics from p onto the proxy.

They must be added after the fact using Proxy.SetToxic.

@sirupsen
Copy link
Contributor

yeah this is a known "issue". @xthexder I don't think this is any different in 2.0?

@xthexder
Copy link
Contributor

Yeah, it's not any different currently, just a little less misleading. I think it would be reasonable to allow toxics to be specified in the Populate() function

@miry miry self-assigned this Nov 12, 2021
@miry miry added this to the 2.4.0 milestone Nov 12, 2021
@miry miry mentioned this issue Jan 5, 2022
8 tasks
@miry miry mentioned this issue Mar 3, 2022
18 tasks
@miry miry modified the milestones: 2.4.0, 2.5.0 Mar 3, 2022
@miry miry mentioned this issue Sep 4, 2022
13 tasks
@miry miry modified the milestones: 2.5.0, 2.6.0 Sep 11, 2022
@miry miry removed their assignment Apr 24, 2023
@miry miry removed this from the 2.6.0 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants