Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the schema migration out of collector #156

Closed
srikanthccv opened this issue Jul 2, 2023 · 5 comments
Closed

move the schema migration out of collector #156

srikanthccv opened this issue Jul 2, 2023 · 5 comments
Assignees

Comments

@srikanthccv
Copy link
Member

Running multiple replicas of collectors creates issues, as no atomic lock migration is in place. Some potential options

  1. Use a standalone migration repo/image
  2. Use the init scripts of ClickHouse
@srikanthccv srikanthccv self-assigned this Aug 2, 2023
@nityanandagohain
Copy link
Member

With multiple clickhouse ditry can be resoved by deleting both schema_migrations and logs_attribute_keys table.

@ankitnayan
Copy link
Contributor

Use the init scripts of ClickHouse

we do not need to restart clickhouse for migrations to apply. If we use init scripts of clickhouse, we would have to restart clickhouse whenever we apply migrations

https://andrewlock.net/deploying-asp-net-core-applications-to-kubernetes-part-7-running-database-migrations/

@ELLIOTTCABLE
Copy link

Oof, yeah, being unable to safely run multiple collectors in parallel is a bit of an issue for us.

I think, for the moment, then, our only option is to run signoz-otel-collector as a 'thin', ingest-only instance on a single box; and have our multiple non-forked otel-collector instances feed that "thin" ingestor over OTLP HTTP or something; have the non-forked instances perform any batching/aggregation/transformation … hrm.

@ankitnayan
Copy link
Contributor

When we move out, we can also look to support templating of cluster name as requested in #180

@ankitnayan
Copy link
Contributor

@ELLIOTTCABLE this is in progress and should be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants