Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1854 FN: Proper support of try/catch statements #4940

Closed
pavel-mikula-sonarsource opened this issue Sep 30, 2021 · 0 comments · Fixed by #9450
Closed

Fix S1854 FN: Proper support of try/catch statements #4940

pavel-mikula-sonarsource opened this issue Sep 30, 2021 · 0 comments · Fixed by #9450
Assignees
@pavel-mikula-sonarsource
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: False Negative Rule is NOT triggered when it should be.
Milestone
9.28

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

Many try/catch scenarios are currently muted by MutedSyntaxWalker.

We need to update our LVA to properly support all possible paths there to be able to remove the muting logic.
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: False Negative Rule is NOT triggered when it should be. labels Sep 30, 2021
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Fix S1854 FN: Proper support to try/catch statemens Fix S1854 FN: Proper support of try/catch statemens Sep 30, 2021
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Fix S1854 FN: Proper support of try/catch statemens Fix S1854 FN: Proper support of try/catch statements Sep 30, 2021
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 9.28 milestone Jun 20, 2024
This was referenced Jun 20, 2024
Merged
Merged
@pavel-mikula-sonarsource pavel-mikula-sonarsource linked a pull request Jun 20, 2024 that will close this issue
Fix S1854 FN: Proper support of try/catch statements #9450
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: False Negative Rule is NOT triggered when it should be.
Projects
None yet
Milestone
9.28
Development

Successfully merging a pull request may close this issue.

Fix S1854 FN: Proper support of try/catch statements SonarSource/sonar-dotnet
2 participants
@pavel-mikula-sonarsource @mary-georgiou-sonarsource