Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE: Add BinaryOperation for literals: division, remainder, xor #7267

Closed
3 tasks done
antonioaversa opened this issue May 25, 2023 · 2 comments
Closed
3 tasks done

SE: Add BinaryOperation for literals: division, remainder, xor #7267

antonioaversa opened this issue May 25, 2023 · 2 comments
Assignees
@antonioaversa
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues.
Milestone
9.4

Comments

@antonioaversa
Copy link
Contributor

antonioaversa commented May 25, 2023 •
edited
Loading

Continuation of #7141

  • Support /
  • Support remainder
  • Support ^

See CBDE implementation below for reference.

In case division proves itself to be too difficult, just reset the constraint - see CBDE implementation below for reference.

CBDE implementation of operations: RangeConstraint.cpp
CBDE UTs: RangeConstraintTest.cpp
@antonioaversa antonioaversa added Type: Improvement Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels May 25, 2023
@antonioaversa antonioaversa added this to the 9.2 milestone May 25, 2023
@antonioaversa antonioaversa self-assigned this May 25, 2023
@antonioaversa antonioaversa changed the title SE: Add BinaryOperation for literals: xor and shifts SE: Add BinaryOperation for literals: reminder, xor and shifts May 25, 2023
This was referenced May 25, 2023
Merged
Merged
Merged
@Tim-Pohlmann Tim-Pohlmann changed the title SE: Add BinaryOperation for literals: reminder, xor and shifts SE: Add BinaryOperation for literals: remainder, xor and shifts May 25, 2023
@Tim-Pohlmann Tim-Pohlmann changed the title SE: Add BinaryOperation for literals: remainder, xor and shifts SE: Add BinaryOperation for literals: division, remainder, xor and shifts May 25, 2023
This was referenced May 25, 2023
Closed
Open
@antonioaversa antonioaversa changed the title SE: Add BinaryOperation for literals: division, remainder, xor and shifts SE: Add BinaryOperation for literals: division, remainder, xor May 26, 2023
@antonioaversa
Copy link
Contributor Author

Shifts operations extracted out into a dedicated issue: #7284

@pavel-mikula-sonarsource pavel-mikula-sonarsource modified the milestones: 9.2, 9.3 May 31, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource modified the milestones: 9.3, 9.4 Jun 6, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource modified the milestones: 9.4, 9.5 Jun 20, 2023
@mary-georgiou-sonarsource
Copy link
Contributor

This issue is done.

@mary-georgiou-sonarsource mary-georgiou-sonarsource modified the milestones: 9.5, 9.4 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaversa antonioaversa

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues.
Projects
None yet
Milestone
9.4
Development

No branches or pull requests
4 participants
@antonioaversa @pavel-mikula-sonarsource @mary-georgiou-sonarsource @gregory-paidis-sonarsource