Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix logging and error throwing #1915

Open
waynevanson opened this issue Sep 15, 2020 · 0 comments
Open

tests: fix logging and error throwing #1915

waynevanson opened this issue Sep 15, 2020 · 0 comments

Comments

@waynevanson
Copy link
Contributor

waynevanson commented Sep 15, 2020 •
edited
Loading

Reproduction

Scenario

On current master branch

Steps to Reproduce

Create a failing test and run the tests with yarn test

Describe the bug

Tests will not fail, even if there is a fail in the test.
This is because it always returns and exit 0, even when a fail should result in an exit 1

Expected behavior

Described above.

Version

package version
sortablejs ^1.12.1-alpha
@types/sortablejs N/A

Additional Context

Fix the logging also with logging-ts.
Put the tests in the Sortable Folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@waynevanson