Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkin Aero does not honor the configured Primary Button Text Color #6010

Open
2 tasks done
tcavaletto opened this issue Sep 12, 2024 · 0 comments
Open
2 tasks done
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@tcavaletto
Copy link
Contributor

Description

Submitted on behalf of Trader's Point

When setting the Primary Button text color on CheckinAero, it doesn't actually update: The text color stays white:
image
image

This is because the setting you're able to update in the Theme Styler, @primary-button-color, is only used within the Aero theme (https://github.com/SparkDevNetwork/Rock/blob/develop/RockWeb/Themes/CheckinAero/Styles/_variables.less#L60).

In order for the setting to actually work, it needs to be applied to the @btn-primary-color variable as well so that other .less files can correctly grab it. We used the following code to fix this issue:
image

Actual Behavior

The text color stays white

Expected Behavior

The text color should reflect the configured color

Steps to Reproduce

  • Go to CMS Configuration > Themes > Theme Styler
  • Edit CheckinAero's Primary Button Color
  • Save Theme
  • Open check-in using the Aero Theme
  • See difference

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Reproduced the problem on a fresh install or on the demo site.

Rock Version

v16 and v17

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

2 participants